feat: Export API Errors #1361
Merged
feat: Export API Errors #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tlgimenes
force-pushed
the
feat/export-errors
branch
from
2dab0da to
3d13823
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5c3ddb2:
|
| throw new Error( | ||
| `Search API did not return the following skus: ${missingSkus.join(',')}` | ||
| throw new NotFoundError( | ||
| `Search API did not found the following skus: ${missingSkus.join(',')}` |
There was a problem hiding this comment.
By the time I tested it, it was not working as expected.
Maybe it's a good opportunity to improve this logic here. What do you think?
eduardoformiga
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR exports some errors we throw inside of
@faststore/apiso starters can catch these errors and respond accordingly. For instance, starters can respond 404 when aNotFoundErroris thrown inside@faststore/api.Starters Deploy Preview